Rule to enforce that certain controller methods must "used"#50
Merged
rochamarcelo merged 6 commits intoCakeDC:4.next-cake5from Oct 12, 2025
Merged
Rule to enforce that certain controller methods must "used"#50rochamarcelo merged 6 commits intoCakeDC:4.next-cake5from
rochamarcelo merged 6 commits intoCakeDC:4.next-cake5from
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Had to fix CS too.. also fixed some phpstan deprecations.
Summary
Implements a new PHPStan rule that enforces explicit
returnstatements for controller methods likerender()andredirect()to preventunreachable code and make control flow more explicit.
Fixes #49
Motivation
In CakePHP controllers, methods like
render()andredirect()terminate the response and prevent further code execution. However, withoutan explicit
returnstatement, it's not immediately obvious that subsequent code is unreachable, which can lead to:Examples
Before (Problems Detected)
PHPStan Output:
After (Correct Usage)
Implementation Details
Configuration
The rule is enabled by default. To disable it: